Refactor JWT Vendor to take a claims builder and rename oboEnabled to enabled#5436
Merged
cwperks merged 5 commits intoopensearch-project:mainfrom Jun 25, 2025
Merged
Refactor JWT Vendor to take a claims builder and rename oboEnabled to enabled#5436cwperks merged 5 commits intoopensearch-project:mainfrom
cwperks merged 5 commits intoopensearch-project:mainfrom
Conversation
… enabled Signed-off-by: Craig Perkins <cwperx@amazon.com>
cwperks
requested review from
DarshitChanpura,
RyanL1997,
derek-ho,
nibix,
peternied,
reta,
shikharj05 and
willyborankin
as code owners
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5436 +/- ##
==========================================
- Coverage 72.40% 72.36% -0.05%
==========================================
Files 393 395 +2
Lines 24299 24317 +18
Branches 3714 3713 -1
==========================================
+ Hits 17593 17596 +3
- Misses 4877 4892 +15
Partials 1829 1829
🚀 New features to boost your workflow:
|
RyanL1997
previously approved these changes
Jun 24, 2025
src/main/java/org/opensearch/security/authtoken/jwt/claims/OBOJwtClaimsBuilder.java
Show resolved
Hide resolved
cwperks
changed the title
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
src/main/java/org/opensearch/security/authtoken/jwt/claims/JwtClaimsBuilder.java
Show resolved
Hide resolved
src/main/java/org/opensearch/security/identity/SecurityTokenManager.java
Show resolved
Hide resolved
Signed-off-by: Craig Perkins <cwperx@amazon.com>
RyanL1997
approved these changes
Jun 24, 2025
shikharj05
approved these changes
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a small refactor ahead of cwperks#56 to make the JWTVendor more flexible. Currently the JWTVendor is tailor made for On-Behalf-Of tokens, but will be re-used for API Tokens and needs more flexibility. This PR adds a notion of a JWTClaimsBuilder to build the claims set for different types of tokens issued by the security plugin. This PR adds an OBOJwtClaimsSetBuilder for building the claims set of an OBO token.
It also has a small refactor of
onoEnabled->enabledsince its clear in context what the variable is enabling.Maintenance
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.